Skip to content

Allow setting low values as minimum console size #6130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2017
Merged

Allow setting low values as minimum console size #6130

merged 1 commit into from
Aug 1, 2017

Conversation

@facchinm
Copy link
Member

@facchinm facchinm commented Mar 27, 2017

Fixes #6085 when setting console.lines=0 in preferences.txt

@facchinm
Allow setting low values as minimum console size
0190225 
Fixes arduino#6085 when setting console.lines=0 in preferences.txt
@mastrolinux mastrolinux added the in progress Work on this item is in progress label Mar 27, 2017
@facchinm facchinm added the Component: IDE user interface The Arduino IDE's user interface label Mar 27, 2017
@ArduinoBot
Copy link
Contributor

ArduinoBot commented Mar 27, 2017

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6130-BUILD-681-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6130-BUILD-681-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6130-BUILD-681-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6130-BUILD-681-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6130-BUILD-681-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@Andy2No
Copy link

Andy2No commented Jun 13, 2017 •
edited
Loading

As I understand it, this fix for the minimum console size didn't make it into the 1.8.3 release, as it was a bit rushed. I haven't tried 1.8.3, because I don't want to risk messing up my custom boards (again).

I've been using this build since 30th April, on Windows 7 x64. I hope this fix makes it into the next official release. Until then, I'll stick with this build.

@facchinm facchinm added this to the Release 1.8.3 milestone Jun 14, 2017
@per1234 per1234 mentioned this pull request Jul 6, 2017
Closed
@cmaglie cmaglie modified the milestones: Release 1.8.3, Next Jul 18, 2017
@facchinm facchinm modified the milestones: Release 1.8.4, Next Jul 25, 2017
@facchinm facchinm merged commit ad02e49 into arduino:master Aug 1, 2017
@cmaglie cmaglie deleted the allow_resizing_console_to_zero branch August 28, 2017 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Component: IDE user interface The Arduino IDE's user interface in progress Work on this item is in progress

Projects

None yet

Milestone

Release 1.8.4

Development

Successfully merging this pull request may close these issues.

5 participants

@facchinm @ArduinoBot @Andy2No @cmaglie @mastrolinux