Skip to content

Conversation

@agdl
Copy link
Member

@agdl agdl commented May 8, 2015

This fixes the Wire examples that uses I2C reserved address (from 0 to 7) substituting them with 8 that is the first one available and that can be used.

I also modified the wire reference
http://www.arduino.cc/en/reference/wire
according to this fact.

@cmaglie cmaglie added the Component: Documentation Related to Arduino's documentation content label May 8, 2015
@matthijskooijman
Copy link
Collaborator

This seems like a duplicate of #3100 that was closed for no apparent reason. Why a second PR?

Also, my comments from #3100 have not been addressed, or responded to:

Could you please give this commit a proper commit message, that describes what it does? Just referencing to an issue isn't very friendly wrt searching / scanning of the commit log, and makes the commit message useless if the issue list ever gets lost. If you want to refer to an issue, use the "Fixes #2969" syntax somewhere in the commit message body (i.e. not the first line), which will even cause github to autoclose the issue.

@agdl
Copy link
Member Author

agdl commented May 11, 2015

@matthijskooijman as @ffissore suggested i made a second PR that includes an explanation if what the fix does and this is what I did. For the commit message I will modify it.

This fixes the Wire examples that uses I2C reserved address (from 0 to 7) substituting them with 8 that is the first one available and that can be used.

I also modified the wire reference
http://www.arduino.cc/en/reference/wire
according to this fact.
ffissore added a commit that referenced this pull request May 14, 2015
Fix for #2969 (I2C reserved addresses)
@ffissore ffissore merged commit c14d4fa into arduino:master May 14, 2015
@ffissore ffissore modified the milestone: Release 1.6.5 May 20, 2015
@agdl agdl deleted the fix_i2cexamples branch March 18, 2016 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Documentation Related to Arduino's documentation content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants