Skip to content

Refer to HID to improve the code #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 26 commits into from
Closed

Refer to HID to improve the code #35

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
b095347
Refer to HID to improve the code
MRNIU Mar 16, 2020
1bf6501
Update comments
MRNIU Mar 25, 2020
5678f82
Update library info
MRNIU Mar 25, 2020
94f55a3
Add README
MRNIU Mar 25, 2020
93ece8d
Cleanup code style
MRNIU Mar 25, 2020
de2ae16
Include HID.h
MRNIU Mar 26, 2020
fb0854e
Fix library.properties
MRNIU Apr 18, 2020
fcceb23
Fix src/Keyboard.cpp code style
MRNIU Apr 18, 2020
9723863
Fix src/Keyboard.h code style
MRNIU Apr 18, 2020
c147ae3
Update README, change contributor info
MRNIU Apr 19, 2020
22f7380
Fix typo
MRNIU Apr 19, 2020
29c29e4
Remove unused variable
MRNIU Apr 19, 2020
a590ad4
Replace `tab` with `space`
MRNIU Apr 19, 2020
2610dfd
Remove preprocessor identation
MRNIU Apr 19, 2020
ea52413
Remove #pragma
MRNIU Apr 19, 2020
e9bace4
Add macro: HID_REPORTID_KEYBOARD
MRNIU Apr 19, 2020
6874ac2
Fix up cpde style
MRNIU Apr 20, 2020
9ff8e1a
Add contributors info
MRNIU Apr 23, 2020
6f6f515
Modify code style
MRNIU Apr 23, 2020
32927da
Correct REAMDE syntax errors
MRNIU Apr 23, 2020
a333810
Correct REAMDE syntax errors and remove some unnecessary information
MRNIU Apr 23, 2020
39c2a44
Merge branch 'sync_with_HID' of https://github.com/MRNIU/Keyboard int…
MRNIU Apr 23, 2020
71e3ee3
Correct dead url
MRNIU Apr 23, 2020
7d32d20
Remove ImprovedKeylayouts*.h, and need some time to rewrite.
MRNIU Apr 24, 2020
e7a586c
Use new KeyboardLayouts: from MRNIU/SimpleKernel.
MRNIU Apr 26, 2020
8060150
Remove layouts.
MRNIU May 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions library.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name=Keyboard
version=1.0.2
author=Arduino
version=1.0.3
author=Arduino, MRNIU
Copy link
Contributor

@per1234 per1234 Apr 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I don't think it's appropriate to add this. None of the other contributors have done this.

Copy link
Contributor

@per1234 per1234 Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I apologize if I wasn't clear in my previous review. I meant that I didn't think it was appropriate to add your name to the author field. Your resolution was to remove Arduino from the author field, which is most certainly not appropriate.

maintainer=Arduino <info@arduino.cc>
sentence=Allows an Arduino/Genuino board with USB capabilites to act as a Keyboard.
paragraph=This library plugs on the HID library. It can be used with or without other HID-based libraries (Mouse, Gamepad etc)
Expand Down
Loading