AE-577: Minor improvements to example sketches and some extra comments. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ended purpose; Implemented in "KeyboardAndMouse" sketch the same solution to print mouse data to console, as used in the "Mouse" example.
sebromero
requested changes
Jul 9, 2025
Contributor
sebromero
left a comment
sebromero
left a comment
There was a problem hiding this comment.
Thank you for the PR! Please take a look at my comments
Co-authored-by: Sebastian Romero <s.romero@arduino.cc>
Co-authored-by: Sebastian Romero <s.romero@arduino.cc>
Co-authored-by: Sebastian Romero <s.romero@arduino.cc>
Co-authored-by: Sebastian Romero <s.romero@arduino.cc>
Contributor
|
@cristidragomir97 @bogdanarduino Can you please take a look at the remaining comments? Thank you |
sebromero
deleted the
AE-577_Test_and_review_latest_version_of_Arduino_USBHIDHost
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic comments to the sketches to better explain their intended purpose.
Borrowed the solution to print mouse data to console, from the "Mouse" sketch, to the "KeyboardAndMouse" example, since using multiple "Serial.print()" calls in the callback event handler crashed the application after a couple of seconds.
Ideally, a solution based on queueing the events would be preferred (using the ArduinoQueue.h maybe).