style: make bool flag arguments more readable

Author: ardera

src/plugins/gstplayer.c

@@ -1190,15 +1190,15 @@ struct gstplayer *gstplayer_new(struct flutterpi *flutterpi, const char *uri, vo
 
     p->tracer = flutterpi_get_tracer(flutterpi);
 
+    TRACER_BEGIN(p->tracer, "gstplayer_new()");
+
     value_notifier_init(&p->video_info_notifier, NULL, free);
     value_notifier_init(&p->duration_notifier, NULL, free);
     value_notifier_init(&p->seeking_info_notifier, NULL, free);
     value_notifier_init(&p->buffering_state_notifier, NULL, free);
     change_notifier_init(&p->error_notifier);
     change_notifier_init(&p->eos_notifier);
 
-    TRACER_BEGIN(p->tracer, "gstplayer_new()");
-
     // playbin is more reliable for now than playbin3 (see above)
     p->playbin = gst_element_factory_make("playbin", "playbin");
     if (p->playbin == NULL) {
@@ -1316,6 +1316,8 @@ struct gstplayer *gstplayer_new(struct flutterpi *flutterpi, const char *uri, vo
 
     TRACER_END(p->tracer, "gstplayer_new()");
 
+    LOG_PLAYER_DEBUG(p, "gstplayer_new(\"%s\", %s): %s\n", uri ?: "", play_audio ? "with audio" : "without audio", p->is_live ? "live" : "not live");
+
     return p;
 
 fail_rm_event_source:

src/plugins/gstreamer_video_player/plugin.c

@@ -607,7 +607,7 @@ static int on_create(char *channel, struct platch_obj *object, FlutterPlatformMe
 
     // create our actual player (this doesn't initialize it)
     if (asset != NULL) {
-        player = gstplayer_new_from_asset(flutterpi, asset, package_name, true, false, NULL);
+        player = gstplayer_new_from_asset(flutterpi, asset, package_name, /* play_video */ true, /* play_audio */ false, NULL);
     } else {
         temp = stdmap_get_str(arg, "httpHeaders");
 
@@ -618,7 +618,7 @@ static int on_create(char *channel, struct platch_obj *object, FlutterPlatformMe
             return 0;
         }
 
-        player = gstplayer_new_from_network(flutterpi, uri, format_hint, true, false, NULL, headers);
+        player = gstplayer_new_from_network(flutterpi, uri, format_hint, /* play_video */ true, /* play_audio */ false, NULL, headers);
     }
     if (player == NULL) {
         LOG_ERROR("Couldn't create gstreamer video player.\n");
@@ -1188,14 +1188,14 @@ static int on_create_v2(const struct raw_std_value *arg, FlutterPlatformMessageR
 
     // Create our actual player (this doesn't initialize it)
     if (asset != NULL) {
-        player = gstplayer_new_from_asset(flutterpi, asset, package_name, true, false, NULL);
+        player = gstplayer_new_from_asset(flutterpi, asset, package_name,  /* play_video */ true,  /* play_audio */ false, NULL);
 
         // gstplayer_new_from_network will construct a file:// URI out of the
         // asset path internally.
         free(asset);
         asset = NULL;
     } else if (uri != NULL) {
-        player = gstplayer_new_from_network(flutterpi, uri, format_hint, true, false, NULL, headers);
+        player = gstplayer_new_from_network(flutterpi, uri, format_hint, /* play_video */ true,  /* play_audio */ false, NULL, headers);
 
         // gstplayer_new_from_network will dup the uri internally.
         free(uri);
@@ -1387,14 +1387,14 @@ static int on_create_with_audio(const struct raw_std_value *arg, FlutterPlatform
 
     // Create our actual player (this doesn't initialize it)
     if (asset != NULL) {
-        player = gstplayer_new_from_asset(flutterpi, asset, package_name, true, true, NULL);
+        player = gstplayer_new_from_asset(flutterpi, asset, package_name, /* play_video */ true, /* play_audio */ true, NULL);
 
         // gstplayer_new_from_network will construct a file:// URI out of the
         // asset path internally.
         free(asset);
         asset = NULL;
     } else if (uri != NULL) {
-        player = gstplayer_new_from_network(flutterpi, uri, format_hint, true, true, NULL, headers);
+        player = gstplayer_new_from_network(flutterpi, uri, format_hint, /* play_video */ true, /* play_audio */ true, NULL, headers);
 
         // gstplayer_new_from_network will dup the uri internally.
         free(uri);