Skip to content

Conversation

@ajanikow
Copy link
Collaborator

@ajanikow ajanikow commented Nov 6, 2025

No description provided.

@cla-bot cla-bot bot added the cla-signed label Nov 6, 2025
@ajanikow ajanikow force-pushed the feature/platform/installer_move_to_oci branch from 76ccda4 to 1f6d4ab Compare November 6, 2025 17:52
@ajanikow ajanikow requested a review from Copilot November 6, 2025 17:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the platform installer from using an S3-based chart registry to an OCI (Open Container Initiative) registry approach. The key changes consolidate registry client functionality, add environment variable support for license manager credentials, and introduce a stage-based registry host naming convention.

  • Migrated from S3-based chart repository to OCI registry for Helm chart distribution
  • Consolidated registry client creation into a reusable cli.Registry module
  • Added environment variable support for license manager credentials

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pkg/util/k8sutil/helm/package.go Added Stage field to PackageSpec and GetStage() method with "prd" default
pkg/util/executor/executor.go Added default case with continue in Timeout select statement
pkg/util/cli/registry.go New file implementing registry client factory with configuration support
pkg/util/cli/lm.go Added RegistryHosts method and EnvEnabled support for credentials
pkg/util/cli/flag.go Implemented environment variable loading for flags via GetFromEnv()
pkg/platform/runner.go Replaced flagPlatformEndpoint with flagRegistry in runner
pkg/platform/regclient.go Removed - functionality moved to cli.Registry
pkg/platform/package_registry.go Removed - registry redirection command removed
pkg/platform/package_install.go Updated to use OCI registry, improved logging with structured logger
pkg/platform/package_import.go Updated to use consolidated registry client
pkg/platform/package_export.go Updated to use OCI registry with endpoint-based chart references
pkg/platform/package.go Removed packageRegistry command
pkg/platform/pack/utils.go New file with OCI chart reference and export utilities
pkg/platform/pack/export.go Updated to use OCI registry instead of ChartManager
pkg/platform/flags.go Replaced individual registry flags with cli.Registry
pkg/platform/chart_manager.go Removed - S3-based chart manager no longer needed
docs/cli/arangodb_operator_platform.md Updated documentation to reflect new flags and removed commands
CHANGELOG.md Added bugfix entry for installer OCI migration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +99 to +100
default:
continue
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default case with continue is redundant and serves no purpose. The continue statement at the end of a loop iteration happens automatically. This case can be safely removed without changing behavior.

Suggested change
default:
continue

Copilot uses AI. Check for mistakes.
}

logger.Info("Installed Chart: %s", name)
log.Info("Installed Chart: %s")
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The log message contains a format specifier %s but no corresponding argument is provided. This will print the literal string 'Installed Chart: %s'. Either remove the %s or pass the chart name as an argument.

Suggested change
log.Info("Installed Chart: %s")
log.Info("Installed Chart: %s", name)

Copilot uses AI. Check for mistakes.
return err
}
logger.Info("Updated Service: %s", name)
log.Info("Updated Service: %s", name)
Copy link

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logging statement uses printf-style formatting which is inconsistent with the structured logging approach used elsewhere in the same function (e.g., line 128 uses log.Str()). For consistency, either use structured logging or ensure the logger supports printf-style formatting.

Suggested change
log.Info("Updated Service: %s", name)
log.Info("Updated Service", log.Str("name", name))

Copilot uses AI. Check for mistakes.
@ajanikow ajanikow force-pushed the feature/platform/installer_move_to_oci branch from 1f6d4ab to 9d6b685 Compare November 8, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants