Added test for rotation.

Author: lamai93

pkg/deployment/reconcile/plan_builder.go

@@ -346,15 +346,30 @@ func podNeedsRotation(log zerolog.Logger, p v1.Pod, apiObject metav1.Object, spe
 	}
 
 	// Check resource requirements
-	// Kubernetes will fill in some default values thus this will always rotate the pod.
-	// One could come up with something more sophisticated to check if a rotation is needed. (check if the requirements are more than requested and limits are less than requested)
-	/*if !reflect.DeepEqual(spec.GetServerGroupSpec(group).Resources, k8sutil.GetArangoDBContainerFromPod(&p).Resources) {
+	if resourcesRequireRotation(spec.GetServerGroupSpec(group).Resources, k8sutil.GetArangoDBContainerFromPod(&p).Resources) {
 		return true, "Resource Requirements changed"
-	}*/
+	}
 
 	return false, ""
 }
 
+// resourcesRequireRotation returns true if the resource requirements have changed such that a rotation is required
+func resourcesRequireRotation(wanted, given v1.ResourceRequirements) bool {
+	checkList := func(wanted, given v1.ResourceList) bool {
+		for k, v := range wanted {
+			if gv, ok := given[k]; !ok {
+				return true
+			} else if v.Cmp(gv) != 0 {
+				return true
+			}
+		}
+
+		return false
+	}
+
+	return checkList(wanted.Limits, given.Limits) || checkList(wanted.Requests, given.Requests)
+}
+
 // normalizeServiceAccountName replaces default with empty string, otherwise returns the input.
 func normalizeServiceAccountName(name string) string {
 	if name == "default" {