Added some ideas for pod rotation for changing requirements.

Author: lamai93

pkg/deployment/reconcile/plan_builder.go

@@ -345,6 +345,13 @@ func podNeedsRotation(log zerolog.Logger, p v1.Pod, apiObject metav1.Object, spe
 		return true, "ServiceAccountName changed"
 	}
 
+	// Check resource requirements
+	// Kubernetes will fill in some default values thus this will always rotate the pod.
+	// One could come up with something more sophisticated to check if a rotation is needed. (check if the requirements are more than requested and limits are less than requested)
+	/*if !reflect.DeepEqual(spec.GetServerGroupSpec(group).Resources, k8sutil.GetArangoDBContainerFromPod(&p).Resources) {
+		return true, "Resource Requirements changed"
+	}*/
+
 	return false, ""
 }
 

pkg/util/k8sutil/images.go

@@ -53,3 +53,17 @@ func GetArangoDBImageIDFromPod(pod *corev1.Pod) string {
 	}
 	return ConvertImageID2Image(rawImageID)
 }
+
+// GetArangoDBContainerFromPod returns the ArangoDB container from a pod
+func GetArangoDBContainerFromPod(pod *corev1.Pod) corev1.Container {
+	arangoc := pod.Spec.Containers[0]
+	if len(pod.Status.ContainerStatuses) > 1 {
+		for _, container := range pod.Spec.Containers {
+			if strings.Contains(container.Name, "server") {
+				arangoc = container
+			}
+		}
+	}
+
+	return arangoc
+}

pkg/util/k8sutil/pods.go

@@ -263,6 +263,7 @@ func arangodInitContainer(name, id, engine, alpineImage string, requireUUID bool
 	return c
 }
 
+// filterStorageResourceRequirement filters resource requirements for Storage.
 func filterStorageResourceRequirement(resources v1.ResourceRequirements) v1.ResourceRequirements {
 
 	filterStorage := func(list v1.ResourceList) v1.ResourceList {
@@ -298,7 +299,7 @@ func arangodContainer(image string, imagePullPolicy v1.PullPolicy, args []string
 				Protocol:      v1.ProtocolTCP,
 			},
 		},
-		Resources:    filterStorageResourceRequirement(resources),
+		Resources:    filterStorageResourceRequirement(resources), // Storage is handled via pvcs
 		VolumeMounts: arangodVolumeMounts(),
 	}
 	for k, v := range env {