-
Notifications
You must be signed in to change notification settings - Fork 110
fix: UI Responsiveness of Landing Page #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: UI Responsiveness of Landing Page #142
Conversation
|
@Janhvibabani is attempting to deploy a commit to the AJEET PRATAP SINGH's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Rate limit exceeded@apsinghdev has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 57 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
WalkthroughThree landing-page components receive styling adjustments: Hero switches to a minimum height, Footer adds responsive horizontal gap classes, and Navbar changes button/icon sizing and text wrapping implementation. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related issues
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/web/src/components/landing-sections/Hero.tsx(1 hunks)apps/web/src/components/landing-sections/footer.tsx(1 hunks)apps/web/src/components/landing-sections/navbar.tsx(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
apps/web/src/components/landing-sections/navbar.tsx (1)
apps/web/src/components/icons/icons.tsx (1)
Terminal(1-5)
🔇 Additional comments (2)
apps/web/src/components/landing-sections/Hero.tsx (1)
11-11: LGTM! Good responsive design improvement.Changing from fixed height (
h-[50dvh]) to minimum height (min-h-[50dvh]) allows the hero section to grow on smaller screens when content needs more space, preventing the "Backed by User" badge and other elements from being cramped or cut off.apps/web/src/components/landing-sections/footer.tsx (1)
23-23: LGTM! Improved mobile spacing.Adding
gap-6provides better separation between the "Opensox AI" section and the navigation columns on mobile screens, whilelg:gap-0preserves the original layout on larger screens wherejustify-betweenhandles the spacing.
8949088 to
fdb794e
Compare
|
@Janhvibabani thanks for the contribution, janvi! just looking into it. |
fdb794e to
5a53184
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Fix: Issue #141 (Mobile Responsiveness Issues in Hero, Navbar, and Footer)
This PR addresses the responsiveness problems reported in Issue # and includes layout fixes across the hero section, navbar, and footer for small screens.
Fix 1 — Added Top Margin for “Backed by User” Badge
The badge previously stuck to the very top on mobile due to height + overflow issues.
This has now been corrected with proper spacing.
Fix 2 — Corrected “Get Started” Button in Navbar
On small screens, the button was overflowing and splitting into two lines.
Padding and whitespace were adjusted to ensure the button remains inline and fits properly.
Fix 3 — Added Proper Spacing in Footer
The “Opensox AI” section and Platform column were too close, creating a cluttered appearance on mobile.
Extra spacing was added specifically for small screens.
Summary
Let me know if any additional adjustments are needed!
Summary by CodeRabbit