-
Notifications
You must be signed in to change notification settings - Fork 110
fix: corrected Tailwind classes for search button and typo in README #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: corrected Tailwind classes for search button and typo in README #133
Conversation
|
@srirama-chandra is attempting to deploy a commit to the AJEET PRATAP SINGH's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughTwo straightforward modifications were made: package manager instructions in README.md were updated from npm to pnpm in two installation steps, and the FiltersContainer component's Search button had its fixed width classes removed with hover styling adjustments applied. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
README.md(1 hunks)apps/web/src/components/ui/FiltersContainer.tsx(1 hunks)
🔇 Additional comments (1)
apps/web/src/components/ui/FiltersContainer.tsx (1)
135-135: LGTM! Tailwind classes corrected.The fix properly addresses invalid Tailwind classes:
- Removed non-standard
w-18andlg:w-12(Tailwind's default spacing scale doesn't include 18)- Fixed
hover:bg-white-500tohover:bg-white(white has no shade variants)- Added
hover:text-ox-purplefor proper hover contrast
|
I intended to update the README in apps/web, but since the apps/docs module isn’t fully developed yet, I’ve paused changes to both for now. I’m happy to revisit and update them once docs is ready. |
|
@srirama-chandra please share a screenshot/screenrecording of your changes. |
Screen-Recording.mp4@apsinghdev Simplified button styles — removed invalid widths and redundant lg classes, replaced incorrect hover:bg-white-500 with proper hover:bg-white and added hover:text-ox-purple for better contrast. |
Summary by CodeRabbit
Documentation
Style