-
Notifications
You must be signed in to change notification settings - Fork 198
fix: enable scrolling in execution sheet for small page limit sizes #2558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ConsoleProject ID: Sites (1)
Tip Cursor pagination performs better than offset pagination when loading further pages. |
WalkthroughThe PR threads a new Estimated code review effort🎯 2 (Simple) | ⏱️ ~12–18 minutes
Pre-merge checks and finishing touches✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-09-30T07:41:06.679ZApplied to files:
🔇 Additional comments (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |

What does this PR do?
Problem
When viewing function execution details with only 6 rows per page in the table:
This issue doesn't occur with larger page sizes (12, 24, 48, 96) because the main page becomes scrollable, allowing the sheet to expand fully.
Solution
Added a scrollable container wrapper around the sheet content with:
max-height: calc(100vh - 280px)to constrain height within viewportoverflow-y: autoto enable vertical scrollingThe 280px offset is determined to ensure optimal visibility of the log content across different screen sizes.
Changes Made
File:
sheet.sveltelimitvalue as a prop (passed frompage.svelte>table.svelte>sheet.svelte)<div class={limit === 6 ? 'log-content-scroll' : ''}>.log-content-scrollwrapper for the sheet content to enable scrolling whenlimit === 6max-heightandoverflow-y: autofor the scrollable behaviorTest Plan
Local Testing Performed:
Cross-page Size Testing:
Screenshots/Video
Before Fix (6 rows per page):
https://github.com/user-attachments/assets/71fe7984-bd02-4bfc-9007-eaf4a9468321
After Fix (6 rows per page):
https://github.com/user-attachments/assets/2fc994b3-94c0-435d-82b2-13e98d173dd9
Related PRs and Issues
Fixes #2557
Have you read the Contributing Guidelines on issues?
Yes, I have read and followed the contributing guidelines.
Summary by CodeRabbit
New Features
Improvements