Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions flask_classy.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,9 @@ def build_rule(cls, rule, method=None):
result = "/%s" % "/".join(rule_parts)
return re.sub(r'(/)\1+', r'\1', result)

@classmethod
def get_class_suffix(cls):
return "View"

@classmethod
def get_route_base(cls):
Expand All @@ -259,8 +262,9 @@ def get_route_base(cls):
base_rule = parse_rule(route_base)
cls.base_args = [r[2] for r in base_rule]
else:
if cls.__name__.endswith("View"):
route_base = cls.__name__[:-4].lower()
suffix = cls.get_class_suffix()
if cls.__name__.endswith(suffix):
route_base = cls.__name__[:-len(suffix)].lower()
else:
route_base = cls.__name__.lower()

Expand Down
8 changes: 7 additions & 1 deletion test_classy/test_route_base.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
from flask import Flask
from .view_classes import BasicView, RouteBaseView
from .view_classes import BasicView, RouteBaseView, ModifiedSuffixAPI
from nose.tools import *

app = Flask('route_base')
RouteBaseView.register(app, route_base="/rb_test2/")
ModifiedSuffixAPI.register(app)


def test_route_base_override():
client = app.test_client()
resp = client.get('/rb_test2/')
eq_(b"Index", resp.data)

def test_modified_suffix():
client = app.test_client()
resp = client.get('/modifiedsuffix/')
eq_(b"Modified Suffix", resp.data)
9 changes: 9 additions & 0 deletions test_classy/view_classes.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,15 @@ def after_request(self, name, response):
def index(self):
return "Index"

class ModifiedSuffixAPI(FlaskView):

@classmethod
def get_class_suffix(cls):
return "API"

def index(self):
return "Modified Suffix"

class VariedMethodsView(FlaskView):

def index(self):
Expand Down