Skip to content

Decompose large blocks in FlaskView #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Decompose large blocks in FlaskView #59

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77efdaa
factored special_methods out to a class-level attribute for ease of p…
aroberts Mar 7, 2014
646e2f5
externalized default view route base generation
Jun 30, 2014
7079ab7
Merge remote-tracking branch 'upstream/master'
Jun 30, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions flask_classy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@ class FlaskView(object):
route_base = None
route_prefix = None
trailing_slash = True
special_methods = {
"get": ["GET"],
"put": ["PUT"],
"patch": ["PATCH"],
"post": ["POST"],
"delete": ["DELETE"],
"index": ["GET"],
}

@classmethod
def register(cls, app, route_base=None, subdomain=None, route_prefix=None,
Expand Down Expand Up @@ -95,7 +103,6 @@ def register(cls, app, route_base=None, subdomain=None, route_prefix=None,


members = get_interesting_members(FlaskView, cls)
special_methods = ["get", "put", "patch", "post", "delete", "index"]

for name, value in members:
proxy = cls.make_proxy_method(name)
Expand All @@ -119,11 +126,8 @@ def register(cls, app, route_base=None, subdomain=None, route_prefix=None,

app.add_url_rule(rule, endpoint, proxy, subdomain=subdomain, **options)

elif name in special_methods:
if name in ["get", "index"]:
methods = ["GET"]
else:
methods = [name.upper()]
elif name in cls.special_methods:
methods = cls.special_methods[name]

rule = cls.build_rule("/", value)
if not cls.trailing_slash:
Expand Down Expand Up @@ -259,13 +263,17 @@ def get_route_base(cls):
base_rule = parse_rule(route_base)
cls.base_args = [r[2] for r in base_rule]
else:
if cls.__name__.endswith("View"):
route_base = cls.__name__[:-4].lower()
else:
route_base = cls.__name__.lower()
route_base = cls.default_route_base()

return route_base.strip("/")

@classmethod
def default_route_base(cls):
if cls.__name__.endswith("View"):
return cls.__name__[:-4].lower()
else:
return cls.__name__.lower()


@classmethod
def build_route_name(cls, method_name):
Expand Down