-
Notifications
You must be signed in to change notification settings - Fork 39
feat: Generated JSDocs based on the API reference #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jancurn
wants to merge
18
commits into
master
Choose a base branch
from
feat/jsdocs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a2ca7c3
Generated JSDocs based on API ref
jancurn 90c248f
JSDocs for interfaces
jancurn 83b635d
Fixed lint
jancurn f21b4d7
Better copy
jancurn 1dbbf39
Better copy
jancurn 7f58e0c
Fixed links to API docs
jancurn 7bc9fd1
Fixed existing JSDocs for other functions
jancurn 8857b22
Expanded options
jancurn ef35ff3
Add more docs
jancurn 35bf257
Fixed cases
jancurn a531b88
Fix
jancurn 1142122
Fixes
jancurn 1b49bdd
Fix inadvertent parameter optionality changes in create methods (#798)
Copilot e2bb026
Update src/resource_clients/actor.ts
jancurn 2fc82f1
Update src/resource_clients/run.ts
jancurn 532cfb5
Update src/resource_clients/key_value_store.ts
jancurn be5294d
Update src/resource_clients/task.ts
jancurn c1214ce
Fix JSDoc tag ordering for correct TypeDoc rendering (#802)
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this renders properly
@B4nan could it be due to some custom solution we have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is how it's supposed to look, there is no "native view for
@exampletag".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but shouldn't it be rendered as heading not as explicit
@example?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, i dont think so, those tags are not really supposed to be headings, i'd say the
@exampletag is the only one where i'd expect a block content, the rest is usually inline, like@see, @link, @internal, @deprecated.of course, its up to us how we want it, but if you are asking how the plugin works, i think this is how.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it would look pretty good if we add some vertical padding and lower the left padding. i am actually surprised that it renders the code block correctly with the syntax highlighting :]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Padding for sure, but I think both
@example&@seeshould be headings as they provide sectionsExample section
examples here
See section (or further reading or whatever)
links here
Or technically we could just use markdown as it seems to be accepting it well enough from my local testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are talking about whitelisting some tags that should be rendered as blocks, sure, for
@exampleit makes sense. But generally speaking, they really are mostly inline things, not blocks. Checking the crawlee codebase, I havent seen a single block tag other than@example. Often they don't even need content, e.g.@ignore, @internal(although those won't be part of the docs in our setup), and often the content is a scalar value, not a sentence (like@default 10or@param [options]or@returns number[]).