fix(jsonSchema): use different cache key for schema definition name #7523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/api-platform/core/pull/7481/files#r2480673359
Currently the SchemaFactory has cache, and the generated key is done with
but this signature does not take account the
$typewhich is input or output.BUT the return value of SchemaFactory might be different for input and output.
I see two solution for this:
In Next major this could be eventually renamed...
I made a POC with the new interface.
Do you agree with the issue @soyuka and are you ok with this solution or do you prefer another ?