[SPARK-54358][SDP][FOLLOWUP] Add tableIdentifierToPathString helper method for SDP checkpoint path construction
#53089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
| /** | ||
| * Converts a TableIdentifier to a path string by joining its name parts with the path separator. | ||
| */ | ||
| private def tableIdentifierToPathString(tableIdentifier: TableIdentifier): String = { |
Member
There was a problem hiding this comment.
Please fix the corresponding test case to use this method too.
Contributor
Author
There was a problem hiding this comment.
In general, SystemMetadataSuite reimplements the path construction logic rather than relying on methods in SystemMetadata, to ensure that we'll catch any changes to the behavior if those methods change.
So my inclination is to avoid reusing this helper there for that reason, but I don't mind changing it if you feel strongly.
Member
|
FYI, @sryza . For the follow-up PRs, the Apache Spark community uses As a result, you had better revise the remaining PR title, |
sryza
changed the title
HyukjinKwon
approved these changes
Nov 19, 2025
dongjoon-hyun
changed the title
tableIdentifierToPathString always for SDP checkpoint path construction
dongjoon-hyun
approved these changes
Nov 20, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @sryza and @HyukjinKwon .
Merged to master/4.1 for Apache Spark 4.1.0.
dongjoon-hyun
changed the title
tableIdentifierToPathString always for SDP checkpoint path constructiontableIdentifierToPathString helper method for SDP checkpoint path construction
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 20, 2025
… method for SDP checkpoint path construction ### What changes were proposed in this pull request? Followups from #53070 to improve code clarity. ### Why are the changes needed? Make sure the code for constructing SDP checkpoint directory paths is clear. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ### Was this patch authored or co-authored using generative AI tooling? Closes #53089 from sryza/collide-followups. Authored-by: Sandy Ryza <sandy.ryza@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 10d1b4c) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
… method for SDP checkpoint path construction ### What changes were proposed in this pull request? Followups from apache#53070 to improve code clarity. ### Why are the changes needed? Make sure the code for constructing SDP checkpoint directory paths is clear. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ### Was this patch authored or co-authored using generative AI tooling? Closes apache#53089 from sryza/collide-followups. Authored-by: Sandy Ryza <sandy.ryza@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Followups from #53070 to improve code clarity.
Why are the changes needed?
Make sure the code for constructing SDP checkpoint directory paths is clear.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?