-
Notifications
You must be signed in to change notification settings - Fork 36
Add RS_RasterToWorldCoord #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds two new raster functions (RS_RasterToWorldCoordX and RS_RasterToWorldCoordY) that convert pixel/raster coordinates to world coordinates using affine transformations.
Key changes:
- Implements affine transformation logic for coordinate conversion
- Adds two new scalar UDFs for X and Y coordinate transformation
- Extends benchmark infrastructure to support integer range arguments
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| rust/sedona-raster/src/lib.rs | Exports new affine_transformation module |
| rust/sedona-raster/src/affine_transformation.rs | Core affine transformation implementation with coordinate conversion logic |
| rust/sedona-raster-functions/src/rs_worldcoordinate.rs | Implements RS_RasterToWorldCoordX and RS_RasterToWorldCoordY UDFs |
| rust/sedona-raster-functions/src/register.rs | Registers new coordinate transformation functions |
| rust/sedona-raster-functions/src/lib.rs | Exports rs_worldcoordinate module |
| rust/sedona-raster-functions/benches/native-raster-functions.rs | Adds benchmarks for new coordinate functions |
| rust/sedona-testing/src/benchmark_util.rs | Adds Int32 argument spec support for benchmarking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
paleolimbot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Just curious: Is there also a RS_RasterToWorldCoord() that returns a Geometry?
Adds raster to world coordinate functions for x and y coordinates.
Example run
Bench
45% improvement through inlining.