Skip to content

Enable batching by default #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Enable batching by default #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63a9907
Enable batching by default
BewareMyPower Aug 29, 2024
065b05f
Merge remote-tracking branch 'apache/main' into bewaremypower/enable-…
merlimat Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pulsar/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ def create_producer(self, topic,
max_pending_messages=1000,
max_pending_messages_across_partitions=50000,
block_if_queue_full=False,
batching_enabled=False,
batching_enabled=True,
batching_max_messages=1000,
batching_max_allowed_size_in_bytes=128*1024,
batching_max_publish_delay_ms=10,
Expand Down Expand Up @@ -670,7 +670,7 @@ def create_producer(self, topic,

SNAPPY is supported since Pulsar 2.4. Consumers will need to be at least at that release in order to
be able to receive messages compressed with SNAPPY.
batching_enabled: bool, default=False
batching_enabled: bool, default=True
When automatic batching is enabled, multiple calls to `send` can result in a single batch to be sent to the
broker, leading to better throughput, especially when publishing small messages.
All messages in a batch will be published as a single batched message. The consumer will be delivered
Expand Down
11 changes: 7 additions & 4 deletions tests/pulsar_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,18 +143,21 @@ def test_producer_send_async(self):

sent_messages = []

event = threading.Event()
def send_callback(producer, msg):
sent_messages.append(msg)
if len(sent_messages) >= 3:
event.set()

producer.send_async(b"hello", send_callback)
producer.send_async(b"hello", send_callback)
producer.send_async(b"hello", send_callback)

i = 0
while len(sent_messages) < 3 and i < 100:
time.sleep(0.1)
i += 1
event.wait(3000)
self.assertEqual(len(sent_messages), 3)
for i in range(0, len(sent_messages)):
msg_id = sent_messages[i]
self.assertEqual(msg_id.batch_index(), i)
client.close()

def test_producer_send(self):
Expand Down
Loading