Retry on new partition producer creation failure #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/ProducerTest.cc
Outdated
Comment on lines
666
to
667
| waitUntil(std::chrono::seconds(1), [&producer]() -> bool { return producer.isConnected(); }); | ||
| ASSERT_TRUE(producer.isConnected()); |
Contributor
There was a problem hiding this comment.
You can check the returned value of waitUntil.
ASSERT_TRUE(waitUntil(std::chrono::seconds(1), [&producer]() -> bool { return producer.isConnected(); }));
BewareMyPower
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #319
Motivation
Already created producer should not fail after new partition producers creation failure.
Modifications
ProducerImpl: Add an option retryOnCreationError to control whether to retry on creation errorPartitionedProducerImpl: Use retryOnCreationError=true to create new partition producersVerifying this change
This change added tests and can be verified as follows:
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededBug fix only.
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)