Inject DefaultFileIOFactory in tests #3043
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XN137
force-pushed
the
inject-FileIOFactory-in-tests
branch
from
7dcaf65 to
b7771df
Compare
dimas-b
previously approved these changes
Nov 17, 2025
github-project-automation
bot
moved this from PRs In Progress
to Ready to merge
in Basic Kanban Board
snazy
reviewed
Nov 17, 2025
...e/service/src/test/java/org/apache/polaris/service/task/BatchFileCleanupTaskHandlerTest.java
Outdated
Show resolved
Hide resolved
...ervice/src/test/java/org/apache/polaris/service/task/ManifestFileCleanupTaskHandlerTest.java
Outdated
Show resolved
Hide resolved
also simplify `TaskFileIOSupplier` usage in tests, which allows removal of `TestFileIOFactory`.
XN137
force-pushed
the
inject-FileIOFactory-in-tests
branch
from
b7771df to
236b18a
Compare
snazy
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also simplify
TaskFileIOSupplierusage in tests, which allows removalof
TestFileIOFactory.