Hint/test stabilization: cannot keep TypeMirrors across javac context invocations. #9042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing the failure here:
https://github.com/apache/netbeans/actions/runs/19711486484/attempts/1#summary-56473993246
it reminded me a similar problem elsewhere, so I took a look at the hint. In general, hint analysis and fix application may run in different javac contexts (different javac instances). It probably does not happen commonly, but it might, and it most likely happened in the test run above. And the Fix is keeping a
TypeMirrorfrom the analysis javac context, and tries to work with in the application context, which fails.This PR is handling that using a
TypeMirrorHandle.As a follow-up work, we could try to enhance the test frameworks to always use a different javac instance for analysis and fix application, to avoid trouble like this.
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)