KAFKA-19946: Simplify skipping of empty ShareFetch requests #21033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
apoorvmittal10
approved these changes
Dec 2, 2025
Contributor
apoorvmittal10
left a comment
apoorvmittal10
left a comment
There was a problem hiding this comment.
Thanks for the PR, LGTM!
AndrewJSchofield
added a commit
that referenced
this pull request
Dec 3, 2025
ShareFetch requests can be used to fetch records for share consumers, but in some cases, no records are required and the request is just being used to update the share session or send acknowledgements. As a result, there are situations in which a ShareFetch request would be built, only for it to be entirely empty (no fetch, no asks, no share session update). This PR simplifies the logic for detecting when the request is empty and then to avoid building it entirely. It also adds some tests for this case. Reviewers: Apoorv Mittal <apoorvmittal10@gmail.com>
Member
Author
|
Cherry-picked to 4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShareFetch requests can be used to fetch records for share consumers,
but in some cases, no records are required and the request is just being
used to update the share session or send acknowledgements. As a result,
there are situations in which a ShareFetch request would be built, only
for it to be entirely empty (no fetch, no asks, no share session
update). This PR simplifies the logic for detecting when the request is
empty and then to avoid building it entirely. It also adds some tests
for this case.
Reviewers: Apoorv Mittal apoorvmittal10@gmail.com