-
Notifications
You must be signed in to change notification settings - Fork 393
update prek libraries, make lint #2696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bebb44f to
13fca91
Compare
13fca91 to
1da2f31
Compare
| "I", # isort | ||
| "UP", # pyupgrade | ||
| ] | ||
| ignore = ["E501","E203","B024","B028","UP037", "UP035", "UP006"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a comment here to revisit the zip behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i coudnt find a good way to add a comment for B905 specifically since there are other ignored rules here.
So i created an issue to track and burn these down
#2700
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the issue. I think the zip should be a good one to get in. Currently, we have checks in place to ensure that the lengths are equivalent, but removing them would be beneficial.
|
Thanks for raising this Kevin! I saw this happening in the UV migration PR and thought I was missing something. Looks like this covers PEP 604 which introduces |
Ah that might explain why ruff left |
|
I find |
yea im used to Optional too |
…2701) <!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change Removes ignoring ruff rule [(B905 zip-without-explicit-strict)](https://docs.astral.sh/ruff/rules/zip-without-explicit-strict/) Use `strict=True` in all zip instances Relates to #2700 Follow up to #2696 ## Are these changes tested? Yes, existing test suite ## Are there any user-facing changes? No <!-- In the case of user-facing changes, please add the changelog label. -->
Rationale for this change
Updated prek libraries (
poetry run prek auto-update)This also triggered updates to deprecate
UnionandOptionalsince we no longer support python 3.9Skipping ruff
zip-without-explicit-strict (B905)for nowAre these changes tested?
Yes,
make lintAre there any user-facing changes?