Skip to content

Conversation

@victor09091
Copy link

What is the purpose of the change

Brief change log

  • Updated simple junit 4 test packages to junit 5 test packages

Verifying this change

  • This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? no)
  • If yes, how is the feature documented? (not applicable)

@boring-cyborg
Copy link

boring-cyborg bot commented Nov 9, 2023

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@victor09091 victor09091 changed the title [FLINK-25538][flink-connector-kafka] JUnit5 Migration [FLINK-25538][Connectors/Kafka] Migration flink-connector-kafka from junit4 to junit5 Nov 9, 2023
@MartijnVisser
Copy link
Contributor

@victor09091 Can you please rebase your PR?

@morazow
Copy link

morazow commented May 24, 2024

Hello @victor09091, @MartijnVisser,

Any update on this issue? Otherwise I'd happy to continue the work and finish the migration. Please let me know 👍

@MartijnVisser
Copy link
Contributor

@morazow Feel free to take it over :)

@github-actions
Copy link

This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/

If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale label Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants