[FLINK-35870] Change DEFAULT_KAFKA_TRANSACTION_TIMEOUT in KafkaSinkBuilder #110
Conversation
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(KafkaSinkBuilder.class); | ||
| private static final Duration DEFAULT_KAFKA_TRANSACTION_TIMEOUT = Duration.ofHours(1); | ||
| private static final Duration DEFAULT_KAFKA_TRANSACTION_TIMEOUT = Duration.ofMinutes(15); |
There was a problem hiding this comment.
It seems a reasonable change, but I am concerned about changing the default of an option. The cautious approach would be to introduce a new parameter with the new default, so the user can choose when to move to the new default and there are no unexpected changes in behaviour for minor upgrades.
|
This PR is being marked as stale since it has not had any activity in the last 90 days. If you are having difficulty finding a reviewer, please reach out to the If this PR is no longer valid or desired, please feel free to close it. |
2 participants
change
DEFAULT_KAFKA_TRANSACTION_TIMEOUTinKafkaSinkBuilderclass.The default value is 15 minutes, as shown in the official Kakfa documentation.
So I changed it from 1 hour to 15 minutes and added the test.
