Fix OffsetArray support and clean CategoricalArray support
#556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
- Coverage 87.43% 4.90% -82.54%
==========================================
Files 26 26
Lines 3288 3305 +17
==========================================
- Hits 2875 162 -2713
- Misses 413 3143 +2730 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Invalid indices were used with `OffsetArray`s as 1-based indexing was assumed. Fix this, and always wrap them in a `ToArrow` objet so that they are consistently turned into 1-based arrays. This allows dropping special code for `CategoricalArray` in favor of using the standard `DataAPI.refpool` API combined with the Arrow extension point added to CategoricalArrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid indices were used with
OffsetArrays as 1-based indexing was assumed. Fix this, and always wrap them in aToArrowobjet so that they are consistently turned into 1-based arrays.This allows dropping special code for
CategoricalArrayin favor of using the standardDataAPI.refpoolAPI combined with the Arrow extension point added to CategoricalArrays (JuliaData/CategoricalArrays.jl#415).If this looks good I'll backport JuliaData/CategoricalArrays.jl#415 to a minor CategoricalArrays release, as currently it's only on master (soon to become 1.0), which explains why CI fails. Another interesting option would be to move the Arrow-CategoricalArrays extension to Arrow, which would ensure support works even with older CategoricalArray versions. Let me know what you think.