test: add stream route E2E tests with detail page flows #3255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baoyuantop
approved these changes
Nov 17, 2025
Contributor
Author
|
Fixed e2e flakiness: added retry to src/apis/upstreams.ts::deleteAllUpstreams and increased timeouts in stream_routes.ts. I ran CI=true pnpm e2e locally all 27 tests passed. |
- Add stream_routes.crud-required-fields.spec.ts for minimal CRUD - Add stream_routes.crud-all-fields.spec.ts for extended CRUD with optional fields - Add stream_routes.list.spec.ts for pagination testing - Create e2e/utils/ui/stream_routes.ts helper for form interactions - Update stream_routes POM with isIndexPage, isAddPage, isDetailPage assertions All CRUD operations now use detail page for edit/delete workflows instead of relying on non-existent list-page Edit buttons. Tests verify creation lands on detail page, editing works via detail toolbar, and deletion happens through detail dialog with proper list verification. Fixes apache#3085
DSingh0304
force-pushed
the
test/stream-routes-clean
branch
from
fb21719 to
5cfc5c2
Compare
SkyeYoung
requested changes
Nov 21, 2025
Member
|
Also pls fix tests |
Removed pnpm configuration for onlyBuiltDependencies.
- Explains why retry is needed (transient 500 errors in E2E tests) - Documents PAGE_SIZE_MIN usage for efficient total count fetching - Clarifies batch deletion strategy - Documents 404 handling for idempotency in parallel test execution
Contributor
Author
|
The CI is fixed; all tests are passing locally. |
- Increase uiHasToastMsg timeout to 30s for all toast message assertions - Increase stream routes navigation timeouts to 30s - Increase stream routes list cell visibility timeouts to 30s - Add waitForLoadState after page reload in SSL test - Increase pagination test timeout to 10s - Add toast message wait in stream routes CRUD tests These changes ensure tests pass reliably in slower CI environments while maintaining the principle that API calls are only used for setup/teardown. All 76 E2E tests pass successfully with these changes.
…mprove `clearAll` error handling for stream routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why submit this pull request?
What changes will this PR take into?
This PR adds comprehensive E2E test coverage for Stream Routes, which was previously missing from the test suite.
Changes:
stream_routes.crud-required-fields.spec.tsfor minimal CRUD operations testingstream_routes.crud-all-fields.spec.tsfor extended CRUD with optional fields (server_addr, remote_addr, SNI, labels)stream_routes.list.spec.tsfor pagination testinge2e/utils/ui/stream_routes.tshelper module for stream route form interactionsisIndexPage,isAddPage,isDetailPageassertions and navigation helpersTest Flow:
All CRUD operations now use the detail page for edit/delete workflows instead of relying on non-existent list-page Edit buttons. Tests verify:
Related issues
fix #3084
Checklist: