Skip to content

Commit e0bfa2a

Browse files
authored
Merge pull request #4223 from anyproto/ios-5420-restructure-and-update-ai-flow-2
Fix verbose code review output for clean approvals
2 parents 6a76a9c + fa7facb commit e0bfa2a

File tree

5 files changed

+39
-9
lines changed

5 files changed

+39
-9
lines changed

.claude/commands/cpp.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,19 @@ Commits the current changes, performs a code review, applies fixes if needed, th
2727
- Apply CODE_REVIEW_GUIDE.md standards
2828
- Check for bugs, best practices violations, performance issues, security concerns
2929

30-
### 3. Review Findings
30+
### 3. Review Findings and Auto-Proceed
3131
- Present review results to developer
3232
- If issues found, **STOP and discuss** with developer:
3333
- Should we fix the issues now?
3434
- Are the findings valid or false positives?
3535
- Should we proceed anyway?
3636
- **Developer decides next steps** - never auto-amend commits
37+
- **If review is approved (✅)**: Automatically proceed to push and PR without asking
3738

38-
### 4. Push and PR (when approved)
39-
- Only proceed when developer approves
39+
### 4. Push and PR (auto-proceed when approved)
4040
- Push to remote with tracking
4141
- Create pull request with summary
42+
- No confirmation needed when code review is approved
4243

4344
## Branch Handling
4445
When a branch name is provided:

.claude/settings.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@
4343
"mcp__linear__list_issue_labels",
4444
"mcp__linear__get_team",
4545
"mcp__linear__search_documentation",
46-
46+
47+
"SlashCommand(/codeReview)",
48+
4749
"Bash(gh pr list:*)",
4850
"Bash(gh pr diff:*)",
4951
"Bash(git fetch:*)",

.claude/skills/code-review-developer/SKILL.md

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ Context-aware routing to code review guidelines. Helps you conduct thorough, act
4343
✅ **Approved** - No issues found
4444
```
4545

46+
**CRITICAL**: When approving, output ONLY the line above. NO additional explanation, NO listing what the PR does, NO praise. Just the approval line.
47+
4648
**If issues found**:
4749
```
4850
## Bugs/Issues
@@ -218,7 +220,21 @@ For GitHub Actions integration:
218220
✅ **Approved** - No issues found
219221
```
220222

221-
**That's it! Don't add explanations, don't list changes.**
223+
**That's it! Absolutely nothing else. Not even in comments posted to GitHub.**
224+
225+
**❌ WRONG** (too verbose):
226+
```
227+
✅ **Approved** - No issues found
228+
229+
The PR correctly implements per-chat notification overrides:
230+
- Added force list properties with proper subscription keys
231+
- effectiveNotificationMode(for:) method correctly prioritizes...
232+
```
233+
234+
**✅ CORRECT**:
235+
```
236+
✅ **Approved** - No issues found
237+
```
222238

223239
### Example 2: Minor Issues
224240
```

.github/workflows/pr-review-automation.md

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,22 @@
55
- **PR NUMBER**: Pull request number (injected by workflow)
66
- **COMMIT SHA**: Commit SHA being reviewed (injected by workflow)
77

8-
## Review Standards
8+
## 🚨 CRITICAL OUTPUT RULES
99

10-
**Apply the shared review guidelines from:**
11-
`.github/workflows/code-review-guidelines.md`
10+
**If NO issues found:**
11+
```
12+
✅ **Approved** - No issues found
13+
```
14+
15+
**DO NOT add ANY additional text:**
16+
- ❌ NO "The PR correctly implements..."
17+
- ❌ NO explanations of what changed
18+
- ❌ NO lists of what was added/cleaned
19+
- ❌ NO implementation details
20+
- ❌ ONLY the one-line approval message above
1221

13-
Follow all core rules, review sections, common mistakes, and analysis checklist defined in that file.
22+
**If issues ARE found:**
23+
Follow the format from `.claude/skills/code-review-developer/SKILL.md`
1424

1525
## CI-Specific Reference Documentation
1626

CLAUDE.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ make setup-middle # Initial setup
3838

3939
### AI Assistance
4040
- **Always present a detailed action plan before implementing multi-step changes and await approval before proceeding**
41+
- **When code review is approved**: Proceed directly with push and PR creation without asking for confirmation
4142

4243
### 📚 Skills System & Documentation (Progressive Disclosure)
4344

0 commit comments

Comments
 (0)