Skip to content

Commit fa7facb

Browse files
committed
IOS-5420 Fix verbose code review output for clean approvals
1 parent 8738726 commit fa7facb

File tree

2 files changed

+31
-5
lines changed

2 files changed

+31
-5
lines changed

.claude/skills/code-review-developer/SKILL.md

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ Context-aware routing to code review guidelines. Helps you conduct thorough, act
4343
✅ **Approved** - No issues found
4444
```
4545

46+
**CRITICAL**: When approving, output ONLY the line above. NO additional explanation, NO listing what the PR does, NO praise. Just the approval line.
47+
4648
**If issues found**:
4749
```
4850
## Bugs/Issues
@@ -218,7 +220,21 @@ For GitHub Actions integration:
218220
✅ **Approved** - No issues found
219221
```
220222

221-
**That's it! Don't add explanations, don't list changes.**
223+
**That's it! Absolutely nothing else. Not even in comments posted to GitHub.**
224+
225+
**❌ WRONG** (too verbose):
226+
```
227+
✅ **Approved** - No issues found
228+
229+
The PR correctly implements per-chat notification overrides:
230+
- Added force list properties with proper subscription keys
231+
- effectiveNotificationMode(for:) method correctly prioritizes...
232+
```
233+
234+
**✅ CORRECT**:
235+
```
236+
✅ **Approved** - No issues found
237+
```
222238

223239
### Example 2: Minor Issues
224240
```

.github/workflows/pr-review-automation.md

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,22 @@
55
- **PR NUMBER**: Pull request number (injected by workflow)
66
- **COMMIT SHA**: Commit SHA being reviewed (injected by workflow)
77

8-
## Review Standards
8+
## 🚨 CRITICAL OUTPUT RULES
99

10-
**Apply the shared review guidelines from:**
11-
`.github/workflows/code-review-guidelines.md`
10+
**If NO issues found:**
11+
```
12+
✅ **Approved** - No issues found
13+
```
14+
15+
**DO NOT add ANY additional text:**
16+
- ❌ NO "The PR correctly implements..."
17+
- ❌ NO explanations of what changed
18+
- ❌ NO lists of what was added/cleaned
19+
- ❌ NO implementation details
20+
- ❌ ONLY the one-line approval message above
1221

13-
Follow all core rules, review sections, common mistakes, and analysis checklist defined in that file.
22+
**If issues ARE found:**
23+
Follow the format from `.claude/skills/code-review-developer/SKILL.md`
1424

1525
## CI-Specific Reference Documentation
1626

0 commit comments

Comments
 (0)