fix NoCrossover missing offsprings #744
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Jul 18, 2025
oxinabox
approved these changes
Aug 4, 2025
Contributor
Author
|
Any updates on approving this change. The failing tests seemed to have failed due to external causes. Might be worth retrying the CI action to verify. |
blankjul
added a commit
that referenced
this pull request
Nov 16, 2025
Collaborator
|
can you check if the commit above also fixes this issue? |
It does not Consider if you have 3 osprint and 2 parents. Consider the example that the parents are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #743
NoCrossoverdoes random selection which fails to propagate certain parents.This PR ensures that all parents are propagated as offsprings.
Thanks @oxinabox for the catch.