types: tighten permission/control protocol typing; docs: include ‘plan’ modeChore/permission typing docs #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… document 'plan' permission mode; client: type-safe set_permission_mode
Collaborator
|
@Anushavasa15 thanks for this! Mind running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace TODOs with concrete types:
SDKControlPermissionRequest.permission_suggestions: list[PermissionUpdate] | None
SDKControlSetPermissionModeRequest.mode: PermissionMode
BaseHookInput.permission_mode: NotRequired[PermissionMode]
Make ClaudeSDKClient.set_permission_mode accept PermissionMode
Update query() docstring to include the supported 'plan' mode
No behavioral changes; improves type safety and keeps docs in sync with current API