fix: defer CLI path lookup to async context to prevent blocking calls #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move shutil.which() call from __init__ to connect() method - Use asyncio.to_thread() to run _find_cli() in background thread - Prevents blockbuster library from detecting os.access as blocking call - Maintains backward compatibility and minimal code changes Resolves issue where SDK would fail in async environments with blocking call detection libraries like blockbuster. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #324
Fixes issue where
shutil.which("claude")inSubprocessCLITransport.__init__()blocks the event loop, causingblockbuster.BlockingErrorin async environments like LangGraph.Changes
__init__()toconnect()methodasyncio.to_thread()to run blocking operation in background threadFiles Modified
src/claude_agent_sdk/_internal/transport/subprocess_cli.pyTesting
blockbuster.BlockingErrorin async environments