Skip to content

Conversation

@x1101
Copy link
Contributor

@x1101 x1101 commented Oct 16, 2025

Converted docs builds to use nox -e make -- webdocs

Sample output for review from a run in my personal fork

@oraNod oraNod changed the title Convert buidls to use nox Convert builds to use nox Oct 16, 2025
@oraNod
Copy link
Contributor

oraNod commented Oct 17, 2025

@x1101 I don't have permissions to your repo's gha runs but that's OK. I'll push your changes to my own fork and try it there. At first glance your changes look good. They make the workflow simpler by moving things into nox so +1 for that.

@oraNod
Copy link
Contributor

oraNod commented Nov 3, 2025

@x1101 Hey, this looks pretty good to me but I think some of the commits don't look right. Could you rebase your branch against devel and update? I've tested this in my fork and think it's good to go. Thanks very much for this improvement!

@oraNod oraNod added doc builds Relates to building the documentation tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves. labels Nov 3, 2025
@oraNod oraNod changed the title Convert builds to use nox Consolidate doc build steps into the nox "make" session Nov 6, 2025
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @x1101

@oraNod oraNod merged commit 3fba90e into ansible:devel Nov 6, 2025
12 checks passed
@x1101 x1101 deleted the f_1758 branch November 6, 2025 19:09
@webknjaz
Copy link
Member

webknjaz commented Nov 8, 2025

@x1101 FYI it's best to split the nox invocation into two steps — provisioning the env and then running the actual thing. This makes stuff easily visible in CI logs.

@gotmax23
Copy link
Collaborator

gotmax23 commented Nov 8, 2025

That'll be handled once we switch to using the ansible-community nox action.

@webknjaz
Copy link
Member

webknjaz commented Nov 8, 2025

@gotmax23 not really. An action is always one step. Unless it can be called twice with different args.. This is why I prefer reusable workflows these days.

@x1101
Copy link
Contributor Author

x1101 commented Nov 8, 2025

@webknjaz the way the ansible-community nox action is called is two steps (once for setup, once for running actions).

I've got an open PR #3194 that has an example of how that works. (Its still in Draft and I have some work to do, but you should see what I mean).

@webknjaz
Copy link
Member

webknjaz commented Nov 8, 2025

@webknjaz the way the ansible-community nox action is called is two steps (once for setup, once for running actions).

I've got an open PR #3194 that has an example of how that works. (Its still in Draft and I have some work to do, but you should see what I mean).

That's still one step per session. But sessions aren't split into provisioning the venv and executing main payload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc builds Relates to building the documentation tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants