-
Notifications
You must be signed in to change notification settings - Fork 746
Consolidate doc build steps into the nox "make" session #3143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@x1101 I don't have permissions to your repo's gha runs but that's OK. I'll push your changes to my own fork and try it there. At first glance your changes look good. They make the workflow simpler by moving things into nox so +1 for that. |
|
@x1101 Hey, this looks pretty good to me but I think some of the commits don't look right. Could you rebase your branch against devel and update? I've tested this in my fork and think it's good to go. Thanks very much for this improvement! |
oraNod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @x1101
|
@x1101 FYI it's best to split the nox invocation into two steps — provisioning the env and then running the actual thing. This makes stuff easily visible in CI logs. |
|
That'll be handled once we switch to using the ansible-community nox action. |
|
@gotmax23 not really. An action is always one step. Unless it can be called twice with different args.. This is why I prefer reusable workflows these days. |
That's still one step per session. But sessions aren't split into provisioning the venv and executing main payload. |
Converted docs builds to use
nox -e make -- webdocsSample output for review from a run in my personal fork