Fix Unpin rstcheck #2383
Fix Unpin rstcheck #2383
Conversation
ganeshhubale
temporarily deployed
to
github-bot
GitHub Actions
Inactive
Signed-off-by: Ganesh Hubale <ganeshhubale03@gmail.com>
ganeshhubale
force-pushed
the
issue-rstcheck-1710
branch
from
66e631b to
86b8efc
Compare
ganeshhubale
temporarily deployed
to
github-bot
GitHub Actions
Inactive
|
@oraNod Since I'm not actively involved in the docs repo maintenance, I'll leave the review to those who are. |
fair enough! I thought it might be appropriate to highlight. thanks for letting us know. |
| ) | ||
|
|
||
| # Run the checks | ||
| exit_code = runner.run() |
There was a problem hiding this comment.
One problem with runner.run() is that it prints messages in a slightly different format. First, it prints a general success/failure message that's not of the expected format. Then, it uses the format FILE:LINE: MSG instead of FILE:LINE:COL: MSG.
It might be better to simply run runner.check() and handle what runner.print_result() does here.
|
@ganeshhubale looks like this needs to be rebased due to conflicts with |
5 participants
Fixed #1710
Discussion for reference - #2344