fix(@angular/build): dynamically select Vitest DOM environment #31726
+36
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enhances the Vitest unit test builder to intelligently select the default DOM test environment (`jsdom` or `happy-dom`) based on which package is installed in the user's project. Previously, the builder strictly defaulted to `jsdom`. With this update: - The `validateDependencies` function now checks for the presence of either `jsdom` or `happy-dom` when browser-based tests are not configured, providing a more flexible dependency requirement. - A new `findTestEnvironment` helper function is introduced to detect the available DOM environment (`happy-dom` is preferred if installed, otherwise `jsdom`). - The `createVitestConfigPlugin` now uses this helper to dynamically set the `environment` in the Vitest configuration, ensuring a smart default if the user has not explicitly specified one. This improves the out-of-the-box experience by adapting to common project setups and offering more choice in DOM emulation.
clydin
force-pushed
the
unit-test/vitest-environment-auto
branch
from
0bba993 to
b1ce21d
Compare
clydin
added
the
action: review
alan-agius4
approved these changes
Nov 8, 2025
alan-agius4
added
action: merge
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enhances the Vitest unit test builder to intelligently select the default DOM test environment (
jsdomorhappy-dom) based on which package is installed in the user's project.Previously, the builder strictly defaulted to
jsdom. With this update:validateDependenciesfunction now checks for the presence of eitherjsdomorhappy-domwhen browser-based tests are not configured, providing a more flexible dependency requirement.findTestEnvironmenthelper function is introduced to detect the available DOM environment (happy-domis preferred if installed, otherwisejsdom).createVitestConfigPluginnow uses this helper to dynamically set theenvironmentin the Vitest configuration, ensuring a smart default if the user has not explicitly specified one.This improves the out-of-the-box experience by adapting to common project setups and offering more choice in DOM emulation.
NOTE: For advanced scenarios, a custom runner config can be used to customize the environment configuration.