Feature: Custom texture size #23
Closed
+67
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exture of a given input. Also prevented the bugs that would be caused if setting negative width or height or setting texture size as the size of a null texture
…nput texture, as requested in #22
… override the custom texture size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I changed:
Issue #22 asked for support for packing non-square textures, so I added a toggle
Custom texture sizebefore theResolutionfield which, when checked, replaces theResolutionfield with a couple of options to set a custom texture width and height. As requested in the mentioned issue, the default custom size is the size of the first created input (if any) unless it's created before checking theCustom texture sizetoggle.Changes in the UI:
The mentioned toggle, located right on top of the
Resolutionfield.All the new options to set a custom texture size, which appear when the toggle is checked. Note that the
Use size from inputbutton only appears when the user created at least one input.When clicking the
Use size from inputbutton, you get to choose from which of the inputs you added you want to import the texture size.Closes #22