[config] remove deprecated fields

[capcom6]

Summary by CodeRabbit

• Refactor
  • Simplified configuration structure by removing a deprecated wrapper and consolidating related settings.
  • Adjusted hashing interval derivation to use a single, streamlined configuration source.
  • Removed the default device lifetime setting; devices now use an empty/default configuration unless explicitly set.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Removed deprecated configuration structures and fields: the Tasks wrapper and its Tasks field from internal config, UnusedLifetime from the devices config, and simplified HashingInterval derivation to use only the messages configuration value.

Changes

Cohort / File(s)	Summary
Config structure removal internal/config/config.go	Removed Tasks struct wrapper and removed the Tasks field from the Config struct. HashingTask type declaration left unchanged.
Hashing interval derivation internal/config/module.go	Replaced prior derivation (max of cfg.Tasks.Hashing.IntervalSeconds and cfg.Messages.HashingIntervalSeconds) with using only cfg.Messages.HashingIntervalSeconds for messages.Config.HashingInterval.
Devices config cleanup internal/sms-gateway/modules/devices/config.go	Removed UnusedLifetime time.Duration field from public Config struct and removed the now-unused time import.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant Module as module.go
participant ConfigSrc as cfg (file)
participant Messages as messages.Config

Note over Module,ConfigSrc: Previous flow (left) vs New flow (right)
par Previous
    Module->>ConfigSrc: read cfg.Tasks.Hashing.IntervalSeconds
    Module->>ConfigSrc: read cfg.Messages.HashingIntervalSeconds
    Module->>Messages: set HashingInterval = max(Tasks.Hashing.IntervalSeconds, Messages.HashingIntervalSeconds)
end
par New
    Module->>ConfigSrc: read cfg.Messages.HashingIntervalSeconds
    Module->>Messages: set HashingInterval = cfg.Messages.HashingIntervalSeconds
end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Files to check closely:
  • internal/config/module.go: ensure removing cfg.Tasks.Hashing.IntervalSeconds still yields correct runtime behavior and no nil/config-existence assumptions remain.
  • Callers or consumers expecting Config.Tasks or devices.Config.UnusedLifetime: search for usages to verify no cascade breakage.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: removing deprecated configuration fields (Tasks, UnusedLifetime) from multiple files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch config/remove-deprecated-sections

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32879e6 and 583c1ec.

📒 Files selected for processing (3)

• internal/config/config.go (0 hunks)
• internal/config/module.go (1 hunks)
• internal/sms-gateway/modules/devices/config.go (0 hunks)

💤 Files with no reviewable changes (2)

• internal/config/config.go
• internal/sms-gateway/modules/devices/config.go

🚧 Files skipped from review as they are similar to previous changes (1)

• internal/config/module.go

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: E2E
• GitHub Check: Benchmark
• GitHub Check: Test
• GitHub Check: Analyze (go)

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1759faf and 32879e6.

📒 Files selected for processing (3)

• internal/config/config.go (0 hunks)
• internal/config/module.go (1 hunks)
• internal/sms-gateway/modules/devices/config.go (0 hunks)

💤 Files with no reviewable changes (2)

• internal/sms-gateway/modules/devices/config.go
• internal/config/config.go

🧰 Additional context used

🧬 Code graph analysis (1)

internal/config/module.go (3)

internal/config/config.go (2)

• Messages (70-73)
• Config (10-19)

internal/sms-gateway/modules/devices/config.go (1)

• Config (3-4)

internal/sms-gateway/modules/messages/config.go (1)

• Config (5-8)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Benchmark
• GitHub Check: E2E
• GitHub Check: Test
• GitHub Check: Analyze (go)