Skip to content

Fix Unknown battery_low attribute as false #3956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Unknown battery_low attribute as false #3956

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1d4dcf
Fix Unknown battery_low attribute as false
bexelbie Nov 13, 2025
c3edabc
Update battery_low property to allow None type
andrew-codechimp Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions custom_components/battery_notes/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ def last_reported_level(self, value: float):
self.async_update_device_config(device_id=self.device_id, data=entry)

@property
def battery_low(self) -> bool:
def battery_low(self) -> bool | None:
"""Check if battery low against threshold."""
if self.battery_low_template:
return self.battery_low_template_state
Expand All @@ -725,10 +725,12 @@ def battery_low(self) -> bool:
return bool(
float(self.current_battery_level) < self.battery_low_threshold
)
else:
return None
elif self.wrapped_battery_low:
return self.battery_low_binary_state

return False
return None

@property
def rounded_battery_level(self) -> float:
Expand Down
Loading