Provide logo option and fix brand colour bug #435
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- using a different logo is specifically [suggested](https://www.gov.uk/service-manual/design/making-your-service-look-like-govuk#if-your-service-isnt-on-govuk) by the Service Manual - use the GDS logo in the example
- otherwise the text is unreadable if $govuk-brand-colour is too light
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows sites to specify a different logo rather than just remove the GOV.UK logo, as suggested by the Service Manual.
Also fix a bug where a too-light "brand colour" resulted in unreadable review boxes.
And a very tiny possible bug in the readme, I couldn't get the tests to work anyway, but this helped a bit.
TODO: the logo thing at least should probably have a test?