[Admin] Component: Navigation Top List Bar - UI component #272 #327
+47
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinyoo
requested changes
Sep 17, 2024
| { | ||
| <div class="sidebar"> | ||
| <NavMenu /> | ||
| <FluentLayout Style="margin-top: 10px;"> |
Contributor
There was a problem hiding this comment.
Layout 컴포넌트하고 MainLayout 컴포넌트하고 어떤게 더 맞을 것 같은가요? 저는 MainLayout 같아 보이긴 하는데... 어떻게 생각하세요?
| <FluentLayout Style="margin-top: 10px;"> | ||
|
|
||
| <FluentHeader> | ||
| Azure OpenAI Proxy Playground |
Contributor
There was a problem hiding this comment.
여기서 Playground는 어드민 화면에서는 맞지 않으니... 그냥 빼거나 아니면 URL에 따라 /admin 페이지일 경우 Azure OpenAI Proxy &ndash Dashboard하고 /playground 페이지일 경우에는 Azure OpenAI Proxy – Playground 처럼 다이나믹하게 구성할 수 있나요?
Comment on lines
+8
to
+10
| <FluentButton IconEnd="@(new Icons.Regular.Size20.Person().WithColor("Blue"))"> | ||
| Login | ||
| </FluentButton> |
Contributor
There was a problem hiding this comment.
- 이 아이콘을 GitHub 아이콘으로 바꿀 수도 있나요?
- 그리고 문자열은
Login with로 바꾸면 좋을 듯?
Comment on lines
+15
to
25
| <div> | ||
| <FluentNavMenu Width="250"> | ||
| <FluentNavLink Icon="@(new Icons.Regular.Size24.Globe())" Href="/">AOAI Proxy Playground | ||
| </FluentNavLink> | ||
| <FluentNavLink Icon="@(new Icons.Regular.Size24.Home())" Href="/">Home</FluentNavLink> | ||
| @if (this._isAdmin == true) | ||
| { | ||
| <FluentNavLink Icon="@(new Icons.Regular.Size24.Board())" Href="/admin">Admin Dashboard</FluentNavLink> | ||
| } | ||
| </FluentNavMenu> | ||
| </div> |
Contributor
There was a problem hiding this comment.
이 네비 메뉴는 어드민 페이지에서만 보이게 해 주세욥. 플레이그라운드에서는 화면을 풀로 다 쓸 수 있으면 좋겠습니다.
Comment on lines
3
to
+7
| <PageTitle>Admin Page</PageTitle> | ||
| @* | ||
| <AdminTopListBar /> *@ | ||
|
|
||
| <h1>Admin Dashboard Page</h1> | ||
| <h3>Admin Dashboard Page</h3> |
Contributor
There was a problem hiding this comment.
앞서 남긴 코멘트대로 하면 여기서 살짝 논리를 바꾸면 될 듯?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MainLayout.razor수정