-
Notifications
You must be signed in to change notification settings - Fork 171
Release/3.17.0 dev #1866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
damcou
wants to merge
150
commits into
main
Choose a base branch
from
release/3.17.0-dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Release/3.17.0 dev #1866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… operations dropping parent products
…handling MAGE-1083 Collection size caching
3.16.0-dev => 3.17.0-dev
…ped-catalog-3.17.0 MAGE-1357 full reindex dropped catalog fix for 3.17.0
MAGE-1138: Configurable temporary index usage
…3.17 MAGE-1422 Product URL fix for 3.17.0
* Follow camel case for store ID * Fix using queue job's store ID for jobs sorting
…17.0 MAGE-1420: Fix store id for queue job (3.17.0)
#1830) * MAGE-1419 Prevent 422 Insights Event - Add to Cart with Discount (#1780) Adding a product to the cart may trigger a PHP and Algolia error due to the discount amount being too large. ## PHP Error ``` main.CRITICAL: Unable to send add to cart event due to Algolia events model misconfiguration: Discount must be a valid decimal number and total length must be no longer than 16 characters [] [] ``` * MAGE-1419 Add unit test class for EventProcessor * MAGE-1419 Test add to cart conversion * MAGE-1419 Test purchase conversion * MAGE-1419 Refactor and merge unit tests for 3.16 * MAGE-1419 Switch to type casting * MAGE-1434 Remove StoreManager as runtime dependency * MAGE-1434 Utilize Magento derived locale for determining decimial precision * MAGE-1434 Add tests for variable precision per locale * MAGE-1434 Fix convert purchase object ID type casting bug * MAGE-1434 Update change log * MAGE-1434 Add unit test for string IDs on request payload --------- Co-authored-by: PromInc <PromInc@hotmail.com> Co-authored-by: Damien Couchez <damien.couchez@gmail.com>
Co-authored-by: Damien Couchez <damien.couchez@gmail.com>
MAGE-1383 Codacy quality checks 3.17
MAGE-1446: fix product duplication
…ues-3.17.0 MAGE-1455 Handle missing price values 3.17
Function \Algolia\AlgoliaSearch\Block\Algolia::getCurrentCategory always return a category (see \Algolia\AlgoliaSearch\Registry\CurrentCategory::get), so we have to check is the returned category has an ID.
…ock-3.17 MAGE-1453: Fixed category check in configuration block (3.17)
…re-release-3.17.0 # Conflicts: # CHANGELOG.md # Helper/Configuration/NoticeHelper.php # Helper/Entity/Product/PriceManager/ProductWithChildren.php # README.md # Service/Product/BatchQueueProcessor.php # composer.json # etc/module.xml
…-3.17.0 MAGE-1460: update version files and changelog (3.17.0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.