Add AgentTrafficLog functionality for bulk writing and storage #3670
Conversation
![devsecopsbot[bot]](https://avatars.githubusercontent.com/in/963709?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 AI Security analysis: "Scanner found no security issues in this change, but absence of findings does not guarantee safety. Seven files were modified—manual review or additional testing is recommended for complex logic, secrets, or dependency updates."
| Risk Level | AI Score |
|---|---|
| 🟢 NO RISK | 5.0/100 |
Top 0 security issues / 0 total (Critical: 0, High: 0, Medium: 0, Low: 0)
| Title | Location | Recommendation |
|---|---|---|
| — | — | No issues to display |
| return Action.SUCCESS.toUpperCase(); | ||
| } | ||
|
|
||
| public String bulkWriteAgentTrafficLogs() { |
There was a problem hiding this comment.
No need for changes in DbAction for mini-runtime. These actions are for cyborg.
Rather we need to complete the impl in DbActor (which extends DataActor)
| if (params.getRequestParams() != null) { | ||
| log.setApiCollectionId(params.getRequestParams().getApiCollectionId()); | ||
| } | ||
| log.setAccountId(params.getAccountId()); |
There was a problem hiding this comment.
sync with cyborg here as well
| } | ||
|
|
||
| BasicDBObject obj = new BasicDBObject(); | ||
| obj.put("agentTrafficLogs", agentTrafficLogs); |
There was a problem hiding this comment.
As a safety check, we can define some upper limit of payload size, if it exceeds ingest traffic logs in smaller batches.
|
|
||
| public abstract void storeConversationResults(List<AgentConversationResult> conversationResults); | ||
|
|
||
| public abstract void bulkWriteAgentTrafficLogs(List<Object> writesForAgentTrafficLogs); |
There was a problem hiding this comment.
writesForAgentTrafficLogs -> agentTrafficLogs (multiple places)
| * 3. Index on accountId for account-level queries | ||
| * 4. Index on isBlocked for filtering blocked/allowed traffic | ||
| */ | ||
| public void createIndicesIfAbsent() { |
| } | ||
|
|
||
| @Override | ||
| public void bulkWriteAgentTrafficLogs(List<Object> writesForAgentTrafficLogs) { |
There was a problem hiding this comment.
Impl in DBActor as well
| SingleTypeInfoDao.instance.createIndicesIfAbsent(); | ||
| SensitiveSampleDataDao.instance.createIndicesIfAbsent(); | ||
| SampleDataDao.instance.createIndicesIfAbsent(); | ||
| AgentTrafficLogDao.instance.createIndicesIfAbsent(); |
There was a problem hiding this comment.
Should add it to DaoInit as well
No description provided.