fix extension of output files #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiertury
force-pushed
the
fix_output_extensions
branch
from
c63d0e8 to
f7f4d33
Compare
javiertury
force-pushed
the
fix_output_extensions
branch
from
f7f4d33 to
1aaa563
Compare
|
@ajaishankar @hpohlmeyer @javiertury @XMLHexagram can you review this and other pull requests? |
|
I believe - correct me if I'm wrong - that this will fail if your project is I've addressed this on my PR: #59, because I even saw your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declares the package
typeasmoduleand uses.cjsextension for CommonJS files.Fixes #41