Skip to content

Conversation

@dagil-nvidia
Copy link
Contributor

@dagil-nvidia dagil-nvidia commented Dec 3, 2025

docs: update TensorRT-LLM commit for multimodal EPD to v1.2.0rc3

Summary

Updates the TensorRT-LLM commit reference from v1.2.0rc2 to v1.2.0rc3 in the multimodal EPD documentation.

Changes

  • Updated docs/backends/trtllm/multimodal_epd.md to use --tensorrtllm-commit v1.2.0rc3

Motivation

The EPD (Encode-Prefill-Decode) feature requires a specific TensorRT-LLM version. This update pins to the latest release candidate v1.2.0rc3 to ensure users build with the correct tested version.

Testing

  • Documentation only change
  • No code changes

Checklist

  • Commit message follows conventional commit format (docs: prefix)
  • DCO sign-off included (-s)
  • Changes are documentation only
  • GPG signing (note: GPG was not available during commit - use /ok to test <commit-sha> to trigger CI)

Summary by CodeRabbit

  • Documentation
    • Updated TensorRT-LLM dependency version reference in multimodal backend documentation to the latest stable release.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Dan Gil <dagil@nvidia.com>
@dagil-nvidia dagil-nvidia self-assigned this Dec 3, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dagil-nvidia
Copy link
Contributor Author

/ok to test f3925d

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 3, 2025

Walkthrough

Updated documentation file for TensorRT-LLM multimodal EPD to reflect a newer commit version requirement. The TensorRT-LLM commit specified in the enabling instructions was bumped from v1.2.0rc2 to v1.2.0rc3 with no other content modifications.

Changes

Cohort / File(s) Summary
Documentation Updates
docs/backends/trtllm/multimodal_epd.md
Updated required TensorRT-LLM commit version from v1.2.0rc2 to v1.2.0rc3 in enabling instructions

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A version bump hops into place,
From rc2 to rc3, a tiny trace,
Docs now point the way so clear,
Fresh instructions, crisp and near! 🌟

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating TensorRT-LLM commit version in multimodal EPD documentation from v1.2.0rc2 to v1.2.0rc3.
Description check ✅ Passed The description includes all required sections from the template: Overview/Summary, Details/Changes, and context about motivation and testing. It provides clear, complete information about the documentation update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c655585 and f3925d7.

📒 Files selected for processing (1)
  • docs/backends/trtllm/multimodal_epd.md (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-08-30T20:43:10.091Z
Learnt from: keivenchang
Repo: ai-dynamo/dynamo PR: 2797
File: .devcontainer/devcontainer.json:12-12
Timestamp: 2025-08-30T20:43:10.091Z
Learning: In the dynamo project, devcontainer.json files use templated container names (like "dynamo-vllm-devcontainer") that are automatically processed by the copy_devcontainer.sh script to generate framework-specific configurations with unique names, preventing container name collisions.

Applied to files:

  • docs/backends/trtllm/multimodal_epd.md
📚 Learning: 2025-12-02T18:13:40.037Z
Learnt from: PeaBrane
Repo: ai-dynamo/dynamo PR: 4698
File: .github/workflows/container-validation-dynamo.yml:68-68
Timestamp: 2025-12-02T18:13:40.037Z
Learning: In the ai-dynamo/dynamo repository, backend-specific tests (vllm, sglang, trtllm) are intentionally excluded from the container-validation-dynamo.yml workflow using "not (vllm or sglang or trtllm)" because they run in a separate container-validation-backends.yml workflow that has dedicated jobs for each backend. This separation keeps framework-agnostic tests separate from backend-specific tests.

Applied to files:

  • docs/backends/trtllm/multimodal_epd.md
📚 Learning: 2025-07-22T10:22:28.972Z
Learnt from: ptarasiewiczNV
Repo: ai-dynamo/dynamo PR: 2027
File: container/deps/vllm/install_vllm.sh:0-0
Timestamp: 2025-07-22T10:22:28.972Z
Learning: The `--torch-backend=auto` flag works with vLLM installations via uv pip install, even though it's not a standard pip option. This flag is processed by vLLM's build system during installation to automatically match PyTorch distribution with container CUDA versions.

Applied to files:

  • docs/backends/trtllm/multimodal_epd.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and Test - dynamo
🔇 Additional comments (1)
docs/backends/trtllm/multimodal_epd.md (1)

10-12: Version reference updated correctly.

The TensorRT-LLM commit has been properly bumped from v1.2.0rc2 to v1.2.0rc3 in the build instruction. This aligns with the PR objective to pin documentation to the tested release candidate version for the EPD feature.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants