NES Update #58
Open
NES Update #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update upstream from MiSTer Passes 128/128 Accuracy Coin Tests modified lightgun module as it was causing issues with the test rom
agg23
reviewed
Nov 1, 2025
Owner
agg23
left a comment
agg23
left a comment
There was a problem hiding this comment.
Thank you for the PR. I was going to take this and build a workflow that automatically moves commits from upstream over, but it's clear I'm not actually going to get around to it.
A few comments on the Pocket things.
| reg hide_overscan = 0; | ||
| reg [1:0] mask_vid_edges = 0; | ||
| reg [1:0] hide_overscan = 0; | ||
| reg [1:0] mask = 0; |
Comment on lines
+711
to
+712
| wire [11:0] slot_x = (|hide_overscan_s) ? (hide_overscan_s[1] ? X_MSB : X_LSB) : X_DEFAULT; | ||
| wire [11:0] slot_y = (|hide_overscan_s) ? (hide_overscan_s[1] ? Y_MSB : Y_LSB) : Y_DEFAULT; |
| "options": [ | ||
| { | ||
| "value": 0, | ||
| "name": "Normal" |
Owner
There was a problem hiding this comment.
I'm unclear on what these values represent, but for backwards compatibility 0 and 1 should match the setting schema.
Comment on lines
+38
to
+68
| "width": 280, | ||
| "height": 240, | ||
| "aspect_w": 4, | ||
| "aspect_h": 3, | ||
| "rotation": 0, | ||
| "mirror": 0 | ||
| }, | ||
| { | ||
| "width": 256, | ||
| "height": 224, | ||
| "aspect_w": 8, | ||
| "aspect_h": 7, | ||
| { | ||
| "width": 280, | ||
| "height": 240, | ||
| "aspect_w": 47, | ||
| "aspect_h": 40, | ||
| "rotation": 0, | ||
| "mirror": 0 | ||
| } | ||
| }, | ||
| { | ||
| "width": 284, | ||
| "height": 242, | ||
| "aspect_w": 4, | ||
| "aspect_h": 3, | ||
| "rotation": 0, | ||
| "mirror": 0 | ||
| }, | ||
| { | ||
| "width": 284, | ||
| "height": 242, | ||
| "aspect_w": 47, | ||
| "aspect_h": 40, | ||
| "rotation": 0, | ||
| "mirror": 0 | ||
| }, |
Owner
There was a problem hiding this comment.
What is happening with these resolutions? Are they special overscan modes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.