Skip to content

[Go] Fix compile issue in generated bitset XXChoiceValues struct #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Go] Fix compile issue in generated bitset XXChoiceValues struct #1068

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbd4b68
fix bitset XXChoiceValues compile issue
Apr 26, 2025
ce83fb4
fix the comments style
Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/golang/struct/GolangGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1650,8 +1650,12 @@ private void generateChoiceDecls(
String comma = "";
for (final Token token : tokens)
{
// In Go a composite‐literal’s elements must either be untyped constants.
// (which are assignable to any compatible numeric type) or exactly the same type as the field.
// So the untyped constants, such 0, 1 works fine,
// but if using the primite type such as uint64{0} would not works here.
sb.append(comma)
.append(generateLiteral(token.encoding().primitiveType(), token.encoding().constValue().toString()));
.append(token.encoding().constValue().toString());
comma = ", ";
}

Expand Down
Loading