Skip to content

Conversation

@mbaluda
Copy link
Contributor

@mbaluda mbaluda commented Apr 25, 2024

Add an FP test case where the user payload is not of built-in type String. The log injection query should not alert on the sink in this case.

@@ -0,0 +1,11 @@
using { advanced_security.log_injection.sample_entities as db_schema } from '../db/schema';

service Service @(path: '/service') {

Check warning

Code scanning / CodeQL

Entity exposed without authentication Medium test

The CDS service Service is exposed without any authentication.

service Service @(path: '/service') {
/* Entity to send READ/GET about. */
entity ServiceEntity as projection on db_schema.Entity2 excluding { Attribute4 }

Check warning

Code scanning / CodeQL

Entity exposed without authentication Medium test

The CDS entity Service.ServiceEntity is exposed without any authentication.
entity ServiceEntity as projection on db_schema.Entity2 excluding { Attribute4 }

/* API to talk to Service. */
action send (

Check warning

Code scanning / CodeQL

Entity exposed without authentication Medium test

The CDS action Service.send is exposed without any authentication.
@jeongsoolee09 jeongsoolee09 marked this pull request as ready for review January 7, 2025 01:02
@jeongsoolee09 jeongsoolee09 requested a review from lcartey January 7, 2025 01:02
@jeongsoolee09 jeongsoolee09 self-assigned this Jan 7, 2025
Copy link
Contributor

@lcartey lcartey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@lcartey lcartey merged commit df92915 into main Jan 16, 2025
5 checks passed
@lcartey lcartey deleted the mbaluda/type_sanitizer branch January 16, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants