Skip to content

Conversation

@byteclimber
Copy link
Contributor

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Thanks for contributing!

@github-actions
Copy link

This PR will trigger a patch release when merged.

Copy link
Member

@davidaurelio davidaurelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please clean up the PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes from here on look unrelated. Please remove them


if ((
auditType === Audit.AUDIT_CONFIG.TYPES.LHS_MOBILE
|| auditType === Audit.AUDIT_CONFIG.TYPES.LHS_DESKTOP
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is your editor making these whitespace changes automatically?
Please either disable that until we settle on a common formatter, or just don't commit them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants