-
Notifications
You must be signed in to change notification settings - Fork 63
FORMS-18096 : Accessibility Issues with Radio Buttons in Adaptive form Core component #1744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
armaang1729
wants to merge
16
commits into
dev
Choose a base branch
from
FORMS-18096
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
357ffb7
added the fieldset and legend for the radiobutton
04b4740
added check for the label-element
7f17e6c
Delete files
armaang1729 ac453c7
code refactoring
5c2ebf8
added sample forms and cypress testing
74aa775
removed the unused forms from DAM
4a12bfe
modified the resourceType to point to older version of radiobutton
07ce1c6
updated the path for the custom functions populate-radiobutton
1cee379
made new collateral for custom functions populate-radiobuttonv2 and a…
6cfead8
added custom function test for the radioButton v2
fac95ea
updated README for the radiobuttonv2 component
07210f6
added clientlibs for newer version of radiobutton
fa8abca
updated af-clientlibs version for the radiobutton
006aa35
removed the role of the radio group aria-label on the <div> containin…
9b05525
updated the cypress tests
a91705a
modified the test case
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
...ddocuments/core-components-it/samples/customfunctions/populate-radiobuttonv2/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:dam="http://www.day.com/dam/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" xmlns:xmp="http://ns.adobe.com/xap/1.0/" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:fd="http://www.adobe.com/aemfd/fd/1.0" | ||
| jcr:primaryType="dam:Asset"> | ||
| <jcr:content | ||
| jcr:lastModified="{Date}2025-11-04T16:00:00.000+05:30" | ||
| jcr:primaryType="dam:AssetContent" | ||
| sling:resourceType="fd/fm/af/render" | ||
| guide="1" | ||
| type="guide"> | ||
| <metadata | ||
| fd:version="2.1" | ||
| jcr:primaryType="nt:unstructured" | ||
| xmp:CreatorTool="AEM Forms" | ||
| allowedRenderFormat="HTML" | ||
| author="admin" | ||
| availableInMobileApp="{Boolean}false" | ||
| dorTemplateChanged="Boolean" | ||
| dorType="none" | ||
| formmodel="none" | ||
| themeRef="/libs/fd/af/themes/canvas" | ||
| title="Populate-Radiobuttonv2"/> | ||
| </jcr:content> | ||
| </jcr:root> |
7 changes: 7 additions & 0 deletions
7
...t/dam/formsanddocuments/core-components-it/samples/radiobutton/radiobuttonv1/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:rep="internal" | ||
| jcr:mixinTypes="[rep:AccessControllable]" | ||
| jcr:primaryType="sling:Folder" | ||
| lcFolder="{Long}0" | ||
| type="lcFolder" | ||
| /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
...sanddocuments/core-components-it/samples/radiobutton/radiobuttonv1/focustest/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:dam="http://www.day.com/dam/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:fd="http://www.adobe.com/aemfd/fd/1.0" | ||
| jcr:primaryType="dam:Asset"> | ||
| <jcr:content | ||
| jcr:primaryType="dam:AssetContent" | ||
| sling:resourceType="fd/fm/af/render" | ||
| guide="1" | ||
| type="guide"> | ||
| <metadata | ||
| fd:version="2.1" | ||
| jcr:primaryType="nt:unstructured" | ||
| allowedRenderFormat="HTML" | ||
| author="admin" | ||
| availableInMobileApp="{Boolean}false" | ||
| dorTemplateChanged="Boolean" | ||
| dorType="none" | ||
| formmodel="none" | ||
| themeRef="/libs/fd/af/themes/canvas" | ||
| title="focustest"/> | ||
| </jcr:content> | ||
| </jcr:root> | ||
|
|
||
|
|
21 changes: 21 additions & 0 deletions
21
...ents/core-components-it/samples/radiobutton/radiobuttonv1/radiorepeatability/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:dam="http://www.day.com/dam/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:fd="http://www.adobe.com/aemfd/fd/1.0" | ||
| jcr:primaryType="dam:Asset"> | ||
| <jcr:content | ||
| jcr:primaryType="dam:AssetContent" | ||
| sling:resourceType="fd/fm/af/render" | ||
| guide="1" | ||
| type="guide"> | ||
| <metadata | ||
| fd:version="2.1" | ||
| jcr:primaryType="nt:unstructured" | ||
| allowedRenderFormat="HTML" | ||
| author="admin" | ||
| dorType="none" | ||
| formmodel="none" | ||
| themeRef="/libs/fd/af/themes/canvas" | ||
| title="radiorepeatability"/> | ||
| </jcr:content> | ||
| </jcr:root> | ||
|
|
||
|
|
7 changes: 7 additions & 0 deletions
7
...t/dam/formsanddocuments/core-components-it/samples/radiobutton/radiobuttonv2/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:rep="internal" | ||
| jcr:mixinTypes="[rep:AccessControllable]" | ||
| jcr:primaryType="sling:Folder" | ||
| lcFolder="{Long}0" | ||
| type="lcFolder" | ||
| /> |
26 changes: 26 additions & 0 deletions
26
...formsanddocuments/core-components-it/samples/radiobutton/radiobuttonv2/basic/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:dam="http://www.day.com/dam/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" xmlns:xmp="http://ns.adobe.com/xap/1.0/" xmlns:cq="http://www.day.com/jcr/cq/1.0" xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:fd="http://www.adobe.com/aemfd/fd/1.0" | ||
| jcr:primaryType="dam:Asset"> | ||
| <jcr:content | ||
| cq:conf="\0" | ||
| jcr:primaryType="dam:AssetContent" | ||
| sling:resourceType="fd/fm/af/render" | ||
| guide="1" | ||
| type="guide"> | ||
| <metadata | ||
| fd:version="2.1" | ||
| jcr:language="en" | ||
| jcr:primaryType="nt:unstructured" | ||
| xmp:CreatorTool="AEM Forms" | ||
| allowedRenderFormat="HTML" | ||
| author="admin" | ||
| availableInMobileApp="{Boolean}false" | ||
| dorTemplateChanged="Boolean" | ||
| dorType="none" | ||
| formmodel="none" | ||
| themeRef="/libs/fd/af/themes/canvas" | ||
| title="basic"/> | ||
| </jcr:content> | ||
| </jcr:root> | ||
|
|
||
|
|
23 changes: 23 additions & 0 deletions
23
...sanddocuments/core-components-it/samples/radiobutton/radiobuttonv2/focustest/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:dam="http://www.day.com/dam/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:fd="http://www.adobe.com/aemfd/fd/1.0" | ||
| jcr:primaryType="dam:Asset"> | ||
| <jcr:content | ||
| jcr:primaryType="dam:AssetContent" | ||
| sling:resourceType="fd/fm/af/render" | ||
| guide="1" | ||
| type="guide"> | ||
| <metadata | ||
| fd:version="2.1" | ||
| jcr:primaryType="nt:unstructured" | ||
| allowedRenderFormat="HTML" | ||
| author="admin" | ||
| availableInMobileApp="{Boolean}false" | ||
| dorTemplateChanged="Boolean" | ||
| dorType="none" | ||
| formmodel="none" | ||
| themeRef="/libs/fd/af/themes/canvas" | ||
| title="focustest"/> | ||
| </jcr:content> | ||
| </jcr:root> | ||
|
|
||
|
|
21 changes: 21 additions & 0 deletions
21
...ents/core-components-it/samples/radiobutton/radiobuttonv2/radiorepeatability/.content.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <jcr:root xmlns:jcr="http://www.jcp.org/jcr/1.0" xmlns:dam="http://www.day.com/dam/1.0" xmlns:nt="http://www.jcp.org/jcr/nt/1.0" xmlns:sling="http://sling.apache.org/jcr/sling/1.0" xmlns:fd="http://www.adobe.com/aemfd/fd/1.0" | ||
| jcr:primaryType="dam:Asset"> | ||
| <jcr:content | ||
| jcr:primaryType="dam:AssetContent" | ||
| sling:resourceType="fd/fm/af/render" | ||
| guide="1" | ||
| type="guide"> | ||
| <metadata | ||
| fd:version="2.1" | ||
| jcr:primaryType="nt:unstructured" | ||
| allowedRenderFormat="HTML" | ||
| author="admin" | ||
| dorType="none" | ||
| formmodel="none" | ||
| themeRef="/libs/fd/af/themes/canvas" | ||
| title="radiorepeatability"/> | ||
| </jcr:content> | ||
| </jcr:root> | ||
|
|
||
|
|
23 changes: 0 additions & 23 deletions
23
.../formsanddocuments/core-components-it/samples/radiobutton/radiorepeatability/.content.xml
This file was deleted.
Oops, something went wrong.
armaang1729 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.