Skip to content

try: add child note test #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: ticket/64145
Choose a base branch
from
Draft

try: add child note test #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82fbb38
try: add child note test
adamsilverstein Oct 24, 2025
b5fd370
phpcbf
adamsilverstein Oct 24, 2025
1834580
Ensure comments controller returns note type children
adamsilverstein Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/wp-includes/rest-api/endpoints/class-wp-rest-comments-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,6 +1254,8 @@ protected function prepare_links( $comment ) {
array(
'count' => true,
'orderby' => 'none',
'type' => $comment->comment_type,
'status' => 'all',
)
);

Expand Down
34 changes: 34 additions & 0 deletions tests/phpunit/tests/rest-api/rest-comments-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4069,4 +4069,38 @@ public function data_note_status_provider() {
'reopen' => array( 'reopen' ),
);
}

/**
* Test children link for note comment type.
*
* @ticket 64145
*/
public function test_get_note_with_children_link() {
$comment_id_1 = self::factory()->comment->create(
array(
'comment_approved' => 0,
'comment_post_ID' => self::$post_id,
'user_id' => self::$subscriber_id,
'comment_type' => 'note',
)
);

self::factory()->comment->create(
array(
'comment_approved' => 0,
'comment_parent' => $comment_id_1,
'comment_post_ID' => self::$post_id,
'user_id' => self::$subscriber_id,
'comment_type' => 'note',
)
);
wp_set_current_user( self::$admin_id );
$request = new WP_REST_Request( 'GET', sprintf( '/wp/v2/comments/%s', $comment_id_1 ) );
$request->set_param( 'type', 'note' );
$request->set_param( 'context', 'edit' );
$response = rest_get_server()->dispatch( $request );
$this->assertSame( 200, $response->get_status() );

$this->assertArrayHasKey( 'children', $response->get_links() );
}
}